[webkit-reviews] review granted: [Bug 114768] Automate generation of toJS function for classes that need to report extra memory usage : [Attachment 198614] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 114768: Automate generation of toJS function for classes that need to
report extra memory usage
https://bugs.webkit.org/show_bug.cgi?id=114768

Attachment 198614: Patch
https://bugs.webkit.org/attachment.cgi?id=198614&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198614&action=review


r=me

> Source/WebCore/bindings/js/JSDOMBinding.h:528
> +	   typedef char YesType;

Let's call this HasMemoryCostMemberFunction.

> Source/WebCore/bindings/js/JSDOMBinding.h:544
> +	   static NoType memoryCostCheck(U*, TypeChecker<void (BaseMixin::*)(),
&U::memoryCost>* = 0);
> +	   static YesType memoryCostCheck(...);

Let's call these dummy.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2718
> +template <typename T, bool hasReportCostFunction = HasMemoryCost<T>::value >
struct ReportCost;

Let's call this "template<typename T, bool hasMemoryCostMemberFunction =
HasMemoryCostMemberFunction<T>::value> struct ReportMemoryCost".

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2720
> +    static void reportExtraCost(ExecState* exec, T* impl)

Let's call this reportMemoryCost.