[webkit-reviews] review denied: [Bug 114742] [texmap] call setContentsNeedsDisplay() if graphics layer has a content layer : [Attachment 198528] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Víctor M. Jáquez L.
<vjaquez at igalia.com>'s request for review:
Bug 114742: [texmap] call setContentsNeedsDisplay() if graphics layer has a
content layer
https://bugs.webkit.org/show_bug.cgi?id=114742

Attachment 198528: Patch
https://bugs.webkit.org/attachment.cgi?id=198528&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198528&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:1883
> +    if (m_graphicsLayer) {
> +	   if (m_graphicsLayer->hasContentsLayer())
> +	       m_graphicsLayer->setContentsNeedsDisplay();
> +	   else if (m_graphicsLayer->drawsContent())
> +	       m_graphicsLayer->setNeedsDisplay();
> +    }

Calling setContentsNeedsDisplay is undesirable on platforms that don't need it.
It will cauase the contents layer to get backing store in cases where it
shouldn't have it (e.g. background color).

You also need to do a setNeedsDisplay() on the main graphics layer even if you
have a contents layer, since the main graphics layer may be painting
backgrounds and borders.