[webkit-reviews] review granted: [Bug 114733] releaseExecutableMemory() should canonicalize cell liveness data before it scans the GC roots. : [Attachment 198500] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 17 08:50:31 PDT 2013


Mark Hahnenberg <mhahnenberg at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 114733: releaseExecutableMemory() should canonicalize cell liveness data
before it scans the GC roots.
https://bugs.webkit.org/show_bug.cgi?id=114733

Attachment 198500: the patch.
https://bugs.webkit.org/attachment.cgi?id=198500&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
r=me. Maybe we should add an assertion that the Heap has been canonicalized
whenever we're doing anything with root scanning (i.e. inside
getConservativeRegisterRoots, gatherConservativeRoots, etc.)


More information about the webkit-reviews mailing list