[webkit-reviews] review granted: [Bug 114743] BasicShapeFunctions should use RenderStyle instead of StyleResolver : [Attachment 198510] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 114743: BasicShapeFunctions should use RenderStyle instead of StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=114743

Attachment 198510: Patch
https://bugs.webkit.org/attachment.cgi?id=198510&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=198510&action=review


>> Source/WebCore/css/BasicShapeFunctions.h:43
>> +PassRefPtr<BasicShape> basicShapeForValue(RenderStyle* style, RenderStyle*
rootElementStyle, const CSSBasicShape*);
> 
> The parameter name "style" adds no information, so it should be removed. 
[readability/parameter_name] [5]

These should be const. I would put the main input (the shape) first.