[webkit-reviews] review granted: [Bug 114709] Repeated use of decodeAudioData() causes leak : [Attachment 198448] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 16 15:55:54 PDT 2013


Geoffrey Garen <ggaren at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 114709: Repeated use of decodeAudioData() causes leak
https://bugs.webkit.org/show_bug.cgi?id=114709

Attachment 198448: Patch
https://bugs.webkit.org/attachment.cgi?id=198448&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198448&action=review


r=me

> Source/WebCore/Modules/webaudio/AudioBuffer.h:71
> +    size_t extraMemoryCost() const;

Slight nit: from the audio buffer's perspective, this is just "cost", not
"extra cost".


More information about the webkit-reviews mailing list