[webkit-reviews] review granted: [Bug 114706] Need a new layout milestone to notify bundle clients when the header has been flushed : [Attachment 198444] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 114706: Need a new layout milestone to notify bundle clients when the
header has been flushed
https://bugs.webkit.org/show_bug.cgi?id=114706

Attachment 198444: Patch
https://bugs.webkit.org/attachment.cgi?id=198444&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198444&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:382
> +	       if (page->layoutMilestones() & DidFirstFlushForHeaderLayer) {

Maybe we can rename Page::layoutMilestones() to
Page::requestedLayoutMilestones() in a future patch to make its role clearer.

> Source/WebKit2/Shared/API/c/WKPageLoadTypes.h:55
> +    // Note that this enum has a fourth, private member that is defined in
WKPageLoadTypesPrivate.h

I think it would be better to add 
kWKReserved1 = 1 << 3 or something, so that future changes are less likely to
break things.