[webkit-reviews] review granted: [Bug 114402] [CSS Exclusions] polygon shape-inside layout fails : [Attachment 198388] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 114402: [CSS Exclusions] polygon shape-inside layout fails
https://bugs.webkit.org/show_bug.cgi?id=114402

Attachment 198388: Patch
https://bugs.webkit.org/attachment.cgi?id=198388&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198388&action=review


r=me. Just some editorial change requests.

> Source/WebCore/ChangeLog:18
> +	   (WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Avoid
floating point problems when checking intersections with the offset edge based
on minLogicalIntervalTop.

Split the comment into two lines.

> Source/WebCore/ChangeLog:21
> +	   (WebCore::OffsetPolygonEdge::basis): Report what the offset edge is
"based on": a polygon edge, the top of the line, or a (reflex) vertex.

Ditto.

> Source/WebCore/rendering/ExclusionPolygon.h:41
> +    enum Basis { Edge, Vertex, LineTop };

I'd like to have a new line for each enum item. This is usually used nowadays.