[webkit-reviews] review granted: [Bug 114697] PlugIns that resize in user gestures should be immune to snapshotting : [Attachment 198426] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 16 14:02:27 PDT 2013


Tim Horton <timothy_horton at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 114697: PlugIns that resize in user gestures should be immune to
snapshotting
https://bugs.webkit.org/show_bug.cgi?id=114697

Attachment 198426: Patch
https://bugs.webkit.org/attachment.cgi?id=198426&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198426&action=review


> Source/WebCore/html/HTMLPlugInImageElement.cpp:556
> +    if (!m_needsCheckForSizeChange || m_snapshotDecision !=
MaySnapshotWhenResized || wasRecentUserGesture(document()))

the document was not a recent user gesture. perhaps had* or saw*?


More information about the webkit-reviews mailing list