[webkit-reviews] review denied: [Bug 92249] Auto-vectorize compiler hint : [Attachment 154368] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 16 12:53:14 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 92249: Auto-vectorize compiler hint
https://bugs.webkit.org/show_bug.cgi?id=92249

Attachment 154368: Patch
https://bugs.webkit.org/attachment.cgi?id=154368&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Because it disable the inlining, it is not a win-or-neutral situation, you can
easily get slower by adding the attribute.

I think it is best to enable it on a case by case basis by backing it with the
benchmark numbers.


More information about the webkit-reviews mailing list