[webkit-reviews] review canceled: [Bug 114674] [BlackBerry] LayerTexture: check if the graphics context is NULL : [Attachment 198280] Patch

[bugzilla-daemon at webkit.org]

Alberto Garcia <agarcia at igalia.com> has canceled Alberto Garcia
<agarcia at igalia.com>'s request for review:
Bug 114674: [BlackBerry] LayerTexture: check if the graphics context is NULL
https://bugs.webkit.org/show_bug.cgi?id=114674

Attachment 198280: Patch
https://bugs.webkit.org/attachment.cgi?id=198280&action=review

------- Additional Comments from Alberto Garcia <agarcia at igalia.com>
(In reply to comment #2)
> > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:-70
> > -	 gc->addFillRect(BlackBerry::Platform::FloatRect(0, 0, 1, 1));
> Why was this never a problem before? Did the semantics of
> lockBufferDrawable change?

They didn't, it can actually return a null pointer. I don't think it's
the case here anyway but see also bug 114005.

> > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:69
> > +	 if (gc) {
> It is WebKit style to put the temp var declaration in the if.

Ok, fixed.