[webkit-reviews] review denied: [Bug 114367] --minimal build fails with error: Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36: error:=?UTF-8?Q?=20=E2=80=98decode=E2=80=99=20is=20not=20a=20member=20of=20=E2=80=98WebCore?=::=?UTF-8?Q?TextCheckingResult=E2=80=99=20?=: [Attachment 198120] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 15 18:56:59 PDT 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Vlad Vasilyeu
<vasvlad at gmail.com>'s request for review:
Bug 114367: --minimal build fails with error:
Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36: error: ‘decode’ is not a
member of ‘WebCore::TextCheckingResult’
https://bugs.webkit.org/show_bug.cgi?id=114367

Attachment 198120: Patch
https://bugs.webkit.org/attachment.cgi?id=198120&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198120&action=review


FYI, there is a instruction how to contribute a patch to WebKit.
http://www.webkit.org/coding/contributing.html

> Source/WebCore/ChangeLog:3
> +	   [EFL] Fixed build failure with option --minimal 

This patch doesn't touch any files in WebCore. So, you should not update
ChangeLog of WebCore. Do not include this in this patch.

> Source/WebKit2/ChangeLog:7
> +

Please add a description to explain why this patch is added or what is added.


More information about the webkit-reviews mailing list