[webkit-reviews] review granted: [Bug 114563] [WIN] Remove remaining calls to pthread from WTF : [Attachment 197943] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 114563: [WIN] Remove remaining calls to pthread from WTF
https://bugs.webkit.org/show_bug.cgi?id=114563

Attachment 197943: Patch
https://bugs.webkit.org/attachment.cgi?id=197943&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197943&action=review


This change looks good to me, and the EWS seems happy.	If this change is
committed, do we get to remove the pthreads library from Windows?

> Source/WTF/wtf/FastMalloc.cpp:-2864
> -    TlsSetValue(tlsIndex, heap);

Don't we still need to use TlsSetValue?  That's part of WinAPI IIRC. Or does
threadSpecificSet deal with all the different platforms properly?

>> Source/WTF/wtf/ThreadSpecificWin.cpp:43
>> +	static Mutex staticMutex;
> 
> Why this change?

I think it's because DEFINE_STATIC_LOCAL(type, name, arguments) is defined as
"static type& name = *new type arguments".

> Source/WTF/wtf/ThreadSpecificWin.cpp:96
> +    new (*key) PlatformThreadSpecificKey(destructor);

Is placement new supported on all of our compilers?