[webkit-reviews] review granted: [Bug 114621] Initialize logging channels for web processes : [Attachment 198119] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 15 11:38:21 PDT 2013


Alexey Proskuryakov <ap at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 114621: Initialize logging channels for web processes
https://bugs.webkit.org/show_bug.cgi?id=114621

Attachment 198119: Patch
https://bugs.webkit.org/attachment.cgi?id=198119&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Looks OK. Where do you initialize WebKit2 logging channels though, why are they
not together? This is what we have on Mac:

#if !LOG_DISABLED
    WebCore::initializeLoggingChannelsIfNecessary();
    WebKit::initializeLogChannelsIfNecessary();
#endif // !LOG_DISABLED


More information about the webkit-reviews mailing list