[webkit-reviews] review granted: [Bug 114440] Dynamically triggered subframe loads are causing tile churn : [Attachment 198114] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 114440: Dynamically triggered subframe loads are causing tile churn
https://bugs.webkit.org/show_bug.cgi?id=114440

Attachment 198114: patch
https://bugs.webkit.org/attachment.cgi?id=198114&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198114&action=review


r=me, good catch. I wonder if there are cases where the window resize
optimization is too clever and just causing churn.

> Source/WebCore/ChangeLog:8
> +	   In some cases we switch in and out of minimal times multiple times
during page loading. This

minimal times -> minimal tiles

> Source/WebCore/ChangeLog:9
> +	   creates tile churn where we create speculatively tiles and then
throw them out. This can be

speculatively -> speculative

> Source/WebCore/ChangeLog:16
> +	       tiles while waiting response for the initial requests.

waiting -> awaiting

> Source/WebCore/ChangeLog:18
> +	   (WebCore):

<darin>Please remove this useless line. Better yet, please fix the script to
stop generating them!</darin>

> Source/WebCore/ChangeLog:28
> +		   Only switch into minimal coverage mode once per page load.

Indentation is different here.

> Source/WebCore/rendering/RenderLayerBacking.cpp:226
> +	   useMinimalTilesDuringLoading = !frameView->isVisuallyNonEmpty() ||
(frame->page()->progress()->isLoadProgressing() &&
!frameView->wasScrolledByUser());

"!frameView->isVisuallyNonEmpty()" :|