[webkit-reviews] review granted: [Bug 114468] color-index media feature not supported : [Attachment 198075] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 15 03:52:37 PDT 2013


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Rune Lillesveen
<rune at opera.com>'s request for review:
Bug 114468: color-index media feature not supported
https://bugs.webkit.org/show_bug.cgi?id=114468

Attachment 198075: Patch
https://bugs.webkit.org/attachment.cgi?id=198075&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198075&action=review


> Source/WebCore/css/MediaQueryEvaluator.cpp:238
> +static bool color_indexMediaFeatureEval(CSSValue* value, RenderStyle*,
Frame* frame, MediaFeaturePrefix op)
> +{
> +    UNUSED_PARAM(frame);

I would just not add frame, ie just Frame*


More information about the webkit-reviews mailing list