[webkit-reviews] review requested: [Bug 114506] [=?UTF-8?Q?=E1=BA=81ebkitpy?=] Executive.cpu_count() ignores $NUMBER_OF_PROCESSORS : [Attachment 198023] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has asked  for review:
Bug 114506: [ẁebkitpy] Executive.cpu_count() ignores $NUMBER_OF_PROCESSORS
https://bugs.webkit.org/show_bug.cgi?id=114506

Attachment 198023: Patch
https://bugs.webkit.org/attachment.cgi?id=198023&action=review

------- Additional Comments from Manuel Rego Casasnovas <rego at igalia.com>
os.environ.get() returns None, but None has type NoneType and if you use it in
int() it raises a TypeError exception instead of a ValueError. So, I've kept
the if checking that the environment variable is defined and then I've added
ValueError in the catch clause.