[webkit-reviews] review denied: [Bug 114444] ProgressEvent should not be cancelable, at least for FileReader : [Attachment 198019] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Praveen Jadhav
<praveen.j at samsung.com>'s request for review:
Bug 114444: ProgressEvent should not be cancelable, at least for FileReader
https://bugs.webkit.org/show_bug.cgi?id=114444

Attachment 198019: Patch
https://bugs.webkit.org/attachment.cgi?id=198019&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=198019&action=review


> Source/WebCore/ChangeLog:3
> +	   ProgressEvent should provide provision to receive canBubble and
cancelable values.

Please update ChangeLog to match current bug title.

> Source/WebCore/dom/ProgressEvent.cpp:56
> +ProgressEvent::ProgressEvent(const AtomicString& type, bool
lengthComputable, unsigned long long loaded, unsigned long long total, bool
canBubble, bool cancelable)
> +    : Event(type, canBubble, cancelable)

If we never need other values, why make the constructor slower by making this
configurable?

> LayoutTests/fast/files/file-reader-event-listener.html:6
> +<script src="../js/resources/js-test-pre.js"></script>

Please use the rest of js-test functionality here (window.jsTestIsAsync,
finishJSTest()). testRunner.dumpAsText() is the default when using js-test.