[webkit-reviews] review granted: [Bug 114561] REGRESSION(r148128): window.resizeTo doesn't work from Safari address bar. : [Attachment 197936] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 14 15:47:27 PDT 2013
Sam Weinig <sam at webkit.org> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 114561: REGRESSION(r148128): window.resizeTo doesn't work from Safari
address bar.
https://bugs.webkit.org/show_bug.cgi?id=114561
Attachment 197936: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=197936&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197936&action=review
Can this be tested?
> Source/WebCore/page/DOMWindow.cpp:1449
> +bool DOMWindow::canChangeWindowGeometry() const
I agree with Alexey, something like allowedToChangeWindowGeometry would be more
clear. This could also use a comment.
More information about the webkit-reviews
mailing list