[webkit-reviews] review requested: [Bug 113623] fourthTier: FTL should have OSR exit : [Attachment 197920] it runs all benchmarks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 12 23:35:41 PDT 2013


Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 113623: fourthTier: FTL should have OSR exit
https://bugs.webkit.org/show_bug.cgi?id=113623

Attachment 197920: it runs all benchmarks
https://bugs.webkit.org/attachment.cgi?id=197920&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
The only things I changed from the previous patch:

1) Fixed some calling convention goofs.

2) Made reoptimization work for FTL, which mostly required removing some
incorrect assertions in CodeBlock.

3) Fixed CheckStructure, since it was generating wrong IR.

4) Added the FTL_NEW_BLOCK macro and started using it everywhere, it makes IR
more readable when --verboseCompilation=true.

We can now run all of SunSpider, V8, and Kraken with the FTL enabled. :-)


More information about the webkit-reviews mailing list