[webkit-reviews] review granted: [Bug 114538] Query directly for cache partition names : [Attachment 197898] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Jeffrey Pfau
<jpfau at apple.com>'s request for review:
Bug 114538: Query directly for cache partition names
https://bugs.webkit.org/show_bug.cgi?id=114538

Attachment 197898: Patch
https://bugs.webkit.org/attachment.cgi?id=197898&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197898&action=review


r=me  (Wow, that's a lot of indirection to get the list of origins.)

> Source/WebKit2/WebProcess/ResourceCache/WebResourceCacheManager.cpp:59
> +#if USE(CFURLCACHE)
> +    __block
> +#endif
>      MemoryCache::SecurityOriginSet origins;

I think it would be clearer to write it this way:

#if USE(CFURLCACHE)
    __block MemoryCache::SecurityOriginSet origins;
#else
    MemoryCache::SecurityOriginSet origins;
#endif

Also, should the #if check be this since it's the only time that 'origins' is
used in a block?

#if USE(CFURLCACHE) && ENABLE(CACHE_PARTITIONING)
    __block MemoryCache::SecurityOriginSet origins;
#else
    MemoryCache::SecurityOriginSet origins;
#endif