[webkit-reviews] review granted: [Bug 114105] Make Frame's ScriptController an OwnPtr and remove the #include : [Attachment 197882] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 12 14:07:03 PDT 2013


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 114105: Make Frame's ScriptController an OwnPtr and remove the #include
https://bugs.webkit.org/show_bug.cgi?id=114105

Attachment 197882: Patch
https://bugs.webkit.org/attachment.cgi?id=197882&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197882&action=review


> Source/WebKit2/Shared/WebHitTestResult.cpp:29
> +#include <WebCore/KURL.h>
>  #include <WebCore/KURL.h>

duplicate

> Source/WebKit2/Shared/WebHitTestResult.h:24
> -#include <WebCore/FrameView.h>
> -#include <WebCore/HitTestResult.h>
> -#include <WebCore/KURL.h>
> -#include <WebCore/Node.h>
> +#include <WebCore/IntRect.h>

Is this part of the ScriptController.h change, or just a separate good change?


More information about the webkit-reviews mailing list