[webkit-reviews] review granted: [Bug 114483] TimeRanges::nearest() returns incorrect results. : [Attachment 197723] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 12 09:55:41 PDT 2013


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 114483: TimeRanges::nearest() returns incorrect results.
https://bugs.webkit.org/show_bug.cgi?id=114483

Attachment 197723: Patch
https://bugs.webkit.org/attachment.cgi?id=197723&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197723&action=review


> Source/WebCore/testing/Internals.cpp:2149
> +    unsigned count = std::min(startTimes->length(), endTimes->length());

std::min() is unnecessary because you ASSERT above if the lengths are
different.


More information about the webkit-reviews mailing list