[webkit-reviews] review requested: [Bug 32246] Multiple connection attempts to a WebSocket server should not be allowed : [Attachment 197853] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 12 08:53:14 PDT 2013


Lamarque V. Souza <Lamarque.Souza at basyskom.com> has asked  for review:
Bug 32246: Multiple connection attempts to a WebSocket server should not be
allowed
https://bugs.webkit.org/show_bug.cgi?id=32246

Attachment 197853: Patch
https://bugs.webkit.org/attachment.cgi?id=197853&action=review

------- Additional Comments from Lamarque V. Souza
<Lamarque.Souza at basyskom.com>
Proposed patch. The patch is not ready so I am not asking for +cq just yet. I
want to read comments about it before I finish it, specially regarding the
RefPtr/ListHashSet usage and the two FIXME I added to it. Just as a note, I am
using 50 as pending request limit because
LayoutTests/http/tests/websocket/tests/hybi/multiple-connections.html starts 50
connection attempts. Using 50 as limit allows me to avoid editing
multiple-connections.html to lower that value.


More information about the webkit-reviews mailing list