[webkit-reviews] review granted: [Bug 114468] color-index media feature not supported : [Attachment 197730] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Rune Lillesveen
<rune at opera.com>'s request for review:
Bug 114468: color-index media feature not supported
https://bugs.webkit.org/show_bug.cgi?id=114468

Attachment 197730: Patch
https://bugs.webkit.org/attachment.cgi?id=197730&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197730&action=review


> Source/WebCore/css/MediaQueryEvaluator.cpp:246
> +    if (value)
> +	   return numberValue(value, number) && compareValue(0,
static_cast<int>(number), op);
> +
> +    return false;

I would prefer 

if (!value)
    return

return number...