[webkit-reviews] review granted: [Bug 108864] [wk2] REGRESSION (r138858): GIFs don't start playing when they come out of background tabs : [Attachment 197683] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 12 01:30:27 PDT 2013


Antti Koivisto <koivisto at iki.fi> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 108864: [wk2] REGRESSION (r138858): GIFs don't start playing when they come
out of background tabs
https://bugs.webkit.org/show_bug.cgi?id=108864

Attachment 197683: patch
https://bugs.webkit.org/attachment.cgi?id=197683&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Ok, though FrameView is oversized and not a great place for this either. One
option would be to add

static void CachedImage::resumeAnimationsForLoader(CachedResourceLoader*)

which would be called by FrameView::resumeAnimatingImages().

But really, it would be good to have one place for controlling all animation
types. AnimationController would be a fine name for one.


More information about the webkit-reviews mailing list