[webkit-reviews] review granted: [Bug 114494] webkitbot should provide full name, email address, and IRC nicknames on whois : [Attachment 197726] Fixes the bug

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 114494: webkitbot should provide full name, email address, and IRC
nicknames on whois
https://bugs.webkit.org/show_bug.cgi?id=114494

Attachment 197726: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=197726&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197726&action=review


> Tools/Scripts/webkitpy/tool/bot/irc_command.py:285
> +	       return "%s: %s is %s. Why do you ask?" % (nick, search_string,
self._full_record_and_nick(contributor))

Shouldn't this be a unicode string too to avoid borking non-latin1 names? (for
Tor Arne for example).

I think Account also need __unicode__. From a quick look, it seems it only has
__str__.

> Tools/Scripts/webkitpy/tool/bot/irc_command.py:288
>	   return "%s: I'm not sure who you mean?  %s could be '%s'." % (nick,
contributors_string, search_string)

ditto.

> Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py:45
>	   whois = Whois()
>	   self.assertEqual("tom: Usage: whois SEARCH_STRING",
>			     whois.execute("tom", [], None, None))
> -	   self.assertEqual("tom: Adam Barth is abarth (abarth at webkit.org). Why
do you ask?",
> +	   self.assertEqual('tom: Adam Barth is "Adam Barth"
<abarth at webkit.org> (:abarth) (r). Why do you ask?',

[...] need a test for uncommon characters in names.