[webkit-reviews] review denied: [Bug 72816] Add CMake base build system for Apple Windows port : [Attachment 197702] CMake build system for windows ports

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has denied Mark Salisbury
<mark.salisbury at hp.com>'s request for review:
Bug 72816: Add CMake base build system for Apple Windows port
https://bugs.webkit.org/show_bug.cgi?id=72816

Attachment 197702: CMake build system for windows ports
https://bugs.webkit.org/attachment.cgi?id=197702&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
First:THX for the patch.
You mix changes in the cpp files with adding CMake files. Please make
independent changes. As already said at webit-dev, I'd like to add separate
WinCG and WinCairo platform files in a first step and then split out the common
parts. So a PlatformWinCairo does a include(PlatformWin) as OptionsWinCE does
already today in the WinCE port. This avoids the different "if (WTF_USE_...) "
in the CMake files. The reason for this is, that it sould be possible to do a
-DPORT=WinCG or PORT=WinCairo when running CMake to decide the port. Setting
all WTF_* stuff is to complicated (for now).