[webkit-reviews] review canceled: [Bug 114330] Refactor TextTrack and TextTrackList to make it easier to add audio and video tracks : [Attachment 197466] Patch

[bugzilla-daemon at webkit.org]

Brendan Long <b.long at cablelabs.com> has canceled Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 114330: Refactor TextTrack and TextTrackList to make it easier to add audio
and video tracks
https://bugs.webkit.org/show_bug.cgi?id=114330

Attachment 197466: Patch
https://bugs.webkit.org/attachment.cgi?id=197466&action=review

------- Additional Comments from Brendan Long <b.long at cablelabs.com>
This doesn't build since I added the removetrack event, and I need some time to
figure out how to handle some things better.

The most annoying part of this is that Vector<RefPtr<TrackBase> > can't be cast
to Vector<RefPtr<TextTrack> >, which makes TextTrackList.cpp significantly more
complicated than it needs to be. I'm thinking I can just make m_elementTracks
and m_addTrackTracks(?) into Vector<RefPtr<TrackBase> > also, but it will make
the code more complicated. I think if I move the track index and isRendered()
code into TrackBase it will work, I just need to make sure that those make
sense for audio and video tracks.