[webkit-reviews] review requested: [Bug 72816] Add CMake base build system for Apple Windows port : [Attachment 197702] CMake build system for windows ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 11 17:30:44 PDT 2013


Mark Salisbury <mark.salisbury at hp.com> has asked  for review:
Bug 72816: Add CMake base build system for Apple Windows port
https://bugs.webkit.org/show_bug.cgi?id=72816

Attachment 197702: CMake build system for windows ports
https://bugs.webkit.org/attachment.cgi?id=197702&action=review

------- Additional Comments from Mark Salisbury <mark.salisbury at hp.com>
What do people think about having a single Windows CMake platform?

I think life would be easier if we had a single PlatformWin.  I've created a
patch that does that.

Patrick has created PlatformWinCE, here has a patch here that creates
PlatformWinApple, and when support for Cairo is added PlatformWinCairo will be
created too.  I see lots of duplication here that can be easily avoided.

Disclaimer:  The patch is a couple of months out of date.  I'll try to rebase
it tomorrow.


More information about the webkit-reviews mailing list