[webkit-reviews] review granted: [Bug 110743] [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess() : [Attachment 197640] Addressing reviewers comments: CL, member function naming, using private access, etc.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 11 15:14:58 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has granted Adenilson Cavalcanti Silva
<savagobr at yahoo.com>'s request for review:
Bug 110743: [WK2] WebPageProxy loadURL() won't work when called just after
terminateProcess()
https://bugs.webkit.org/show_bug.cgi?id=110743

Attachment 197640: Addressing reviewers comments: CL, member function naming,
using private access, etc.
https://bugs.webkit.org/attachment.cgi?id=197640&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197640&action=review


> Source/WebKit2/ChangeLog:17
> +	   closing connections. Otherwise, WebPageProxy can even be able to
> +	   detect that WebProcess is no longer running, but a call to respawn
> +	   the process will fail.

"Otherwise, WebPageProxy can even be able to detect that WebProcess [...]"

> Source/WebKit2/ChangeLog:19
> +	   To fix this issues, this patch moves the cleanup code to a shared
private function

"this issue" or "these issues".

> Tools/TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:83
> +    EXPECT_TRUE(testHelper->firstSuccessfulLoad);

This can never be false.


More information about the webkit-reviews mailing list