[webkit-reviews] review granted: [Bug 114462] Cannot scroll to footer on a page with overflow:hidden on the body : [Attachment 197668] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 11 13:58:11 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 114462: Cannot scroll to footer on a page with overflow:hidden on the body
https://bugs.webkit.org/show_bug.cgi?id=114462

Attachment 197668: Patch
https://bugs.webkit.org/attachment.cgi?id=197668&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197668&action=review


> Source/WebCore/page/FrameView.cpp:614
> +	   || (m_frame->page() && m_frame->page()->mainFrame() == m_frame &&
(headerHeight() || footerHeight()));

Why don't we have Frame::isMainFrame()? :(


More information about the webkit-reviews mailing list