[webkit-reviews] review granted: [Bug 114412] Add platform support for -webkit-background-blend-mode to CG context with background color : [Attachment 197641] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mihai Tica <mitica at adobe.com>'s
request for review:
Bug 114412: Add platform support for -webkit-background-blend-mode to CG
context with background color
https://bugs.webkit.org/show_bug.cgi?id=114412

Attachment 197641: Patch
https://bugs.webkit.org/attachment.cgi?id=197641&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197641&action=review


Is there measurable performance impact for the code paths that now do extra
work for non-blend cases? I’m guessing no.

What does this do for graphics back ends other than CG?

> Source/WebCore/ChangeLog:16
> +	   (GraphicsContext):

Would be nice to remove this bogus change log line and/or fix the script that
added it.

> LayoutTests/css3/compositing/effect-background-blend-mode-color.html:5
> +  if (window.testRunner) {
> +   
window.testRunner.overridePreference("WebKitAcceleratedCompositingEnabled",
"1");
> +  }

Extra braces not needed here. Why test only in this mode? Don’t we want to test
both modes?