[webkit-reviews] review granted: [Bug 114409] Merge CharacterClassTable into CharacterClass : [Attachment 197501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 11 10:52:46 PDT 2013


Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 114409: Merge CharacterClassTable into CharacterClass
https://bugs.webkit.org/show_bug.cgi?id=114409

Attachment 197501: Patch
https://bugs.webkit.org/attachment.cgi?id=197501&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197501&action=review


> Source/JavaScriptCore/yarr/YarrPattern.cpp:180
> +	   OwnPtr<CharacterClass> characterClass = adoptPtr(new
CharacterClass());

I like omitting the () in cases like this.


More information about the webkit-reviews mailing list