[webkit-reviews] review granted: [Bug 114451] Implement more logic in StorageAreaMap : [Attachment 197638] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 114451: Implement more logic in StorageAreaMap
https://bugs.webkit.org/show_bug.cgi?id=114451

Attachment 197638: Patch
https://bugs.webkit.org/attachment.cgi?id=197638&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197638&action=review


> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:101
> +	   // FIXME: If this is sent to another process, the source storage
area won't make sense.

I don't understand this comment. What another process? Is this for the case
when a process is restarted after a crash?

Please elaborate, unless you plan to address this very soon.

> Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp:133
> +    // FIXME: This should use a special sendSync flag to indicate that we
don't want to process incoming messages while waiting for a reply.
> +    // (This flag does not yet exist).

It's not very obvious why.