[webkit-reviews] review granted: [Bug 114057] [GTK][AC] use a smart pointer for GList and ClutterCanvas : [Attachment 196672] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 114057: [GTK][AC] use a smart pointer for GList and ClutterCanvas
https://bugs.webkit.org/show_bug.cgi?id=114057

Attachment 196672: Patch
https://bugs.webkit.org/attachment.cgi?id=196672&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196672&action=review


> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:286
> +    int width =
std::max(static_cast<int>(ceilf(clutter_actor_get_width(actor))), 1);
> +    int height =
std::max(static_cast<int>(ceilf(clutter_actor_get_height(actor))), 1);

fwiw, I'm not sure this size or 1 is required with ClutterCanvas, might be
worth checking.