[webkit-reviews] review denied: [Bug 35300] (GTK) HTTP 307 after a 303 after a POST re-sends POST data from the original request : [Attachment 196679] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 11 06:41:39 PDT 2013


Gustavo Noronha (kov) <gns at gnome.org> has denied Alberto Garcia
<agarcia at igalia.com>'s request for review:
Bug 35300: (GTK) HTTP 307 after a 303 after a POST re-sends POST data from the
original request
https://bugs.webkit.org/show_bug.cgi?id=35300

Attachment 196679: Patch
https://bugs.webkit.org/attachment.cgi?id=196679&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Yeah, the URI is to remain read-only for API users, it should only be updated
by internal code, that is why it's done the way it is. I'm OK with adding an
internal call to update it instead of poking the private structure, though. I
think adding a new property for original-uri is a good idea, since it maintains
the API expectations while still providing complete information.

All that said, wk1 is in maintenance mode and there was a decision not to add
new API to it unless strictly necessary, so I wonder, do we really want to fix
this test at this point?

r- for the change in API expectation, adding a new property sounds like a
better solution.


More information about the webkit-reviews mailing list