[webkit-reviews] review granted: [Bug 114418] [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver. : [Attachment 197516] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Glenn Adams <glenn at skynav.com>'s
request for review:
Bug 114418: [webkitpy] Remove lingering return_exit_code usage in scm_mock and
rebaselineserver.
https://bugs.webkit.org/show_bug.cgi?id=114418

Attachment 197516: Patch
https://bugs.webkit.org/attachment.cgi?id=197516&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197516&action=review


> Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py:121
> +	   except ScriptError, e:

Please don't use one-letter variable name like e. Spell out error.

> Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py:157
> +	   except ScriptError, e:

Ditto.