[webkit-reviews] review granted: [Bug 114386] [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later : [Attachment 197509] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Glenn Adams
<glenn at skynav.com>'s request for review:
Bug 114386: [webkitpy] SVNTest fails four tests when using subversion client
1.7 or later
https://bugs.webkit.org/show_bug.cgi?id=114386

Attachment 197509: Patch
https://bugs.webkit.org/attachment.cgi?id=197509&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197509&action=review


> Tools/ChangeLog:7
> +

I think you should have a word about why the test were failing on 1.7 and
later.

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:194
> +	       if exit_code and exit_code != 1:

Maybe just my coding style but to avoid magic numbers I would do:
    added_tracked_file_exit_code = 1
    if exit_code and exit_code != added_tracked_file_exit_code: