[webkit-reviews] review denied: [Bug 114386] [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later : [Attachment 197498] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Glenn Adams <glenn at skynav.com>'s
request for review:
Bug 114386: [webkitpy] SVNTest fails four tests when using subversion client
1.7 or later
https://bugs.webkit.org/show_bug.cgi?id=114386

Attachment 197498: Patch
https://bugs.webkit.org/attachment.cgi?id=197498&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197498&action=review


On my second thought, we shouldn't be adding code that nobody really uses. r-.

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:196
> +	   if return_exit_code:
> +	       return exit_code

Please mention, in the change log, it's okay to return 1 in some cases.