[webkit-reviews] review denied: [Bug 114308] [EFL] build fails with error: missing binary operator before token "(" : [Attachment 197177] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 10 20:27:38 PDT 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Ed Bartosh
<bartosh at gmail.com>'s request for review:
Bug 114308: [EFL] build fails with error: missing binary operator before token
"("
https://bugs.webkit.org/show_bug.cgi?id=114308

Attachment 197177: Patch
https://bugs.webkit.org/attachment.cgi?id=197177&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197177&action=review


> Tools/ChangeLog:9
> +	   * MiniBrowser/efl/main.c: Included config.h to be able to use ENABLE
macro

Where does MiniBrowser use ENABLE macro ?

> Tools/MiniBrowser/efl/main.c:20
> +#include "config.h"

MiniBrowser is sample program. So, MiniBrowser should not use WebKit function
except for public APIs


More information about the webkit-reviews mailing list