[webkit-reviews] review denied: [Bug 114378] [CSS Filters] Move all the FilterOperation classes to rendering/style folder : [Attachment 197407] Patch V1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 10 15:41:51 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Alexandru Chiculita
<achicu at adobe.com>'s request for review:
Bug 114378: [CSS Filters] Move all the FilterOperation classes to
rendering/style folder
https://bugs.webkit.org/show_bug.cgi?id=114378

Attachment 197407: Patch V1
https://bugs.webkit.org/attachment.cgi?id=197407&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197407&action=review


> Source/WebCore/ChangeLog:13
> +	   for the -webkit-filter CSS property. ReferenceFilterOperation
already had references to WebCore
> +	   structures, so this patch will also fix that layering violation.

But existing platform/ code references these classes, e.g.
platform/graphics/GraphicsLayer.h includes FilterOperation.h


More information about the webkit-reviews mailing list