[webkit-reviews] review granted: [Bug 114314] FindBanner matches are offset when the WKView has a header or footer : [Attachment 197395] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 114314: FindBanner matches are offset when the WKView has a header or
footer
https://bugs.webkit.org/show_bug.cgi?id=114314

Attachment 197395: Patch
https://bugs.webkit.org/attachment.cgi?id=197395&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197395&action=review


> Source/WebCore/ChangeLog:22
> +	   Use scrollOffsetRealtiveToDocument() where we were previously making
this 

Still misspelledt here.

> Source/WebCore/platform/ScrollView.cpp:753
> +    IntSize offsetRelativeToTotalContents = scrollOffset() + IntSize(0,
headerHeight());

offsetIncludingHeader?

> Source/WebCore/rendering/RenderLayer.h:404
> +    LayoutRect getRectToExpose(const LayoutRect& visibleRect, LayoutRect&
visibleRectRelativeToDocument, const LayoutRect& exposeRect, const
ScrollAlignment& alignX, const ScrollAlignment& alignY);

visibleRectRelativeToDocument should be a const LayoutRect&, no?