[webkit-reviews] review granted: [Bug 114377] External XML entities are not loaded with modern libxml2 : [Attachment 197394] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 114377: External XML entities are not loaded with modern libxml2
https://bugs.webkit.org/show_bug.cgi?id=114377

Attachment 197394: proposed fix
https://bugs.webkit.org/attachment.cgi?id=197394&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197394&action=review


> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:506
> +    xmlCtxtUseOptions(parser, XML_PARSE_NOENT);

It might be nice to have a comment explaining why this is the right option to
use.

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:531
>      // Copy the sax handler

Wow, lame comment.

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:534
>      xmlCtxtUseOptions(parser, XML_PARSE_NODICT | XML_PARSE_NOENT);

It might still be nice to have a comment explaining why these are the right
options to use.