[webkit-reviews] review denied: [Bug 114314] FindBanner matches are offset when the WKView has a header or footer : [Attachment 197392] Patch with new names
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 10 13:20:14 PDT 2013
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 114314: FindBanner matches are offset when the WKView has a header or
footer
https://bugs.webkit.org/show_bug.cgi?id=114314
Attachment 197392: Patch with new names
https://bugs.webkit.org/attachment.cgi?id=197392&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197392&action=review
> Source/WebCore/ChangeLog:17
> + New function subtracts out the headerHeight() to treat the top of
the document at
> + (0,0).
Awkward line breaking.
> Source/WebCore/WebCore.exp.in:1227
> +__ZNK7WebCore10ScrollView30scrollOffsetRealtiveToDocumentEv
Typo.
More information about the webkit-reviews
mailing list