[webkit-reviews] review granted: [Bug 112418] FrameLoaderClient::assignIdentifierToInitialRequest() not called for the main resource when loaded from the memory cache : [Attachment 197215] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 112418: FrameLoaderClient::assignIdentifierToInitialRequest() not called
for the main resource when loaded from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=112418

Attachment 197215: Patch
https://bugs.webkit.org/attachment.cgi?id=197215&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197215&action=review


> Source/WebCore/loader/DocumentLoader.cpp:610
> +	   addResponse(response);
>	   frameLoader()->notifier()->dispatchDidReceiveResponse(this,
m_identifierForLoadWithoutResourceLoader, m_response, 0);

A little strange to use response on one line and m_response on the next to
refer to the same object.