[webkit-reviews] review denied: [Bug 50418] Optimize computation of visual overflow when opacity changes : [Attachment 197256] Proposed patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Bruno Abinader
<bruno.abinader at basyskom.com>'s request for review:
Bug 50418: Optimize computation of visual overflow when opacity changes
https://bugs.webkit.org/show_bug.cgi?id=50418

Attachment 197256: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=197256&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197256&action=review


> Source/WebCore/rendering/RenderObject.cpp:1735
> +    // if we are not composited or have no children neither overflow.

Do you mean "no children that overflow" or "no children, nor overflow"?

> Source/WebCore/rendering/RenderObject.cpp:1739
> +	   if ((contextSensitiveProperties &
ContextSensitivePropertyOpacityToggle) && (!isCompositedLayer || (!isEmpty() &&
!hasOverflowClip())))
> +	       diff = StyleDifferenceLayout;

I don't think this (!isEmpty() && !hasOverflowClip()) test makes sense. You
need to do layout when opacity toggles to update z-order lists, visual overflow
etc.