[webkit-reviews] review granted: [Bug 114344] Refactor Editor::markAndReplaceFor before fixing autocorrection bugs : [Attachment 197230] More cleanups

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 114344: Refactor Editor::markAndReplaceFor before fixing autocorrection
bugs
https://bugs.webkit.org/show_bug.cgi?id=114344

Attachment 197230: More cleanups
https://bugs.webkit.org/attachment.cgi?id=197230&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197230&action=review


Looks ok to me. just few nits in the change log.

> Source/WebCore/ChangeLog:8
> +	   This patch refactors Editor::markAndReplaceFor so that we can start
fixing bugs in a sane staet.

Typo: state.

> Source/WebCore/ChangeLog:12
> +	   In particular, shouldMarkSpelling used to be set false when
shouldShowCorrectionPanel was true

to false

> Source/WebCore/ChangeLog:14
> +	   since shouldMarkSpelling was only referred once after the
assignment.

typo referenced.

> Source/WebCore/editing/Editor.cpp:2265
> +	       bool existingMarkersPermitReplacement =
m_alternativeTextController->processMarkersOnTextToBeReplacedByResult(&results[
i], rangeToReplace.get(), replacedString);

Can this be const as well?