[webkit-reviews] review granted: [Bug 114336] Removed bitrotted TimeoutChecker code : [Attachment 197273] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 10 09:49:00 PDT 2013
Alexey Proskuryakov <ap at webkit.org> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 114336: Removed bitrotted TimeoutChecker code
https://bugs.webkit.org/show_bug.cgi?id=114336
Attachment 197273: Patch
https://bugs.webkit.org/attachment.cgi?id=197273&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197273&action=review
Oh, this smell of bitrot in the morning...
> Source/JavaScriptCore/ChangeLog:31
> + * dfg/DFGGPRInfo.h:
> + (GPRInfo):
> + * jit/JIT.cpp:
> + (JSC):
> + * jit/JIT.h:
> + (JIT):
> + * jit/JITStubs.cpp:
> + (JSC):
This is so unhelpful. Personally, I think that even file lists are unnecessary
in ChangeLogs for patches like this, but listing namespaces is just wrong.
More information about the webkit-reviews
mailing list