[webkit-reviews] review granted: [Bug 108203] Allow direct compositing of background images : [Attachment 194529] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 10 09:33:03 PDT 2013
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Noam Rosenthal
<noam at webkit.org>'s request for review:
Bug 108203: Allow direct compositing of background images
https://bugs.webkit.org/show_bug.cgi?id=108203
Attachment 194529: Patch
https://bugs.webkit.org/attachment.cgi?id=194529&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194529&action=review
> Source/WebCore/platform/graphics/GraphicsLayer.h:330
> + virtual void setContentsTilePhase(const IntPoint& p) {
m_contentsTilePhase = p; }
> + IntPoint contentsTilePhase() const { return m_contentsTilePhase; }
Would be nice to add a comment saying what this represents. What is it relative
to; the GrpahicsLayer bounds? The content layer bounds? The offsetFromRenderer?
More information about the webkit-reviews
mailing list