[webkit-reviews] review denied: [Bug 114029] Incorrect evaluation of resolution media queries : [Attachment 197253] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 10 06:28:19 PDT 2013
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Rune Lillesveen
<rune at opera.com>'s request for review:
Bug 114029: Incorrect evaluation of resolution media queries
https://bugs.webkit.org/show_bug.cgi?id=114029
Attachment 197253: Patch
https://bugs.webkit.org/attachment.cgi?id=197253&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197253&action=review
Please do the style fix in a separate patch.
So "print" now follows the dpi of the screen? It would be nice that the high
resolution images were used when printing
> Source/WebCore/ChangeLog:14
> +
> + To pass the coding style, the media feature enums and method names
> + have been changed.
We usually don't do such changes together with a bug fix. It should really be a
separate patch. The style comments are only "educational"
More information about the webkit-reviews
mailing list